fix: replace the search dialog to avoid a client-side exception #3
+13
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent - Updated `generateStaticParams` to filter out existing root paths and return a structured array with the root path first for optional catch-all routes. - Refactored the `Heading` component to simplify rendering logic and improve accessibility by incorporating an `id` prop for anchor links.
…tegration - Changed the development server port in `package.json` to 3001 for better accessibility. - Integrated `SearchDialog` from `fumadocs-ui` and updated `RootProvider` to include a custom search dialog in `layout.tsx`. - Refactored `DefaultSearchDialog` to export as a named function and improved query handling in `search.tsx`.
- Added `dynamic = 'force-static'` export to the `page.tsx` file to ensure static rendering for dynamic routes, improving performance and SEO.
- Removed unused `SearchDialog` import from `layout.tsx` to streamline the code. - Deleted the `dynamic` export from `page.tsx`, as it is no longer necessary for static rendering.
- Removed the port specification from the development server command in `package.json` to streamline the setup process.
…nt server command - Simplified the `generateStaticParams` function in `page.tsx` to directly return parameters from the source, enhancing clarity. - Updated the development server command in `package.json` to specify port 3001 for improved accessibility.
- Updated the `generateStaticParams` function to include a root path entry, ensuring proper handling of the root path alongside parameters generated from the source.
- Streamlined the rendering logic in the `Heading` component by consolidating the anchor link creation and default properties into a single `useRender` call, enhancing code clarity and maintainability.
- Removed the port specification from the development server command in `package.json` to simplify the setup process.
- Eliminated the unused `prefetch` prop in the `SidebarItem` component, enhancing code clarity and reducing unnecessary complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the search dialog with
DefaultSearchDialogbecause the built-in dialog throws a client-side exception during searches.Simplify the
generateStaticParamsimplementation.Set prefetch to "auto" because some links are broken when using static export, but it works well in development mode and normal build mode. I haven't investigated the root cause yet.