providers: add support for hetzner cloud#125
Conversation
|
@LKaemmerling Would you mind taking a look at this from the Hetzner Cloud team? Feel free to suggest changes. |
| use serde_json; | ||
|
|
||
| #[cfg(not(test))] | ||
| const URL: &str = "http://169.254.169.254/2009-04-04"; |
There was a problem hiding this comment.
Is there a public reference where this endpoint JSON response is documented?
There was a problem hiding this comment.
@LKaemmerling Could you answer this from the Hetzner team? It seems there is indeed no public documentation of this endpoint (i.e. on https://docs.hetzner.cloud/)
There was a problem hiding this comment.
This endpoint is not public documented.
There was a problem hiding this comment.
Is the endpoint stable? (will it continue to behave as the current implementation?)
There was a problem hiding this comment.
Since it is not public documented, we can not guarantee that it will behave the same way as the current implementation.
There was a problem hiding this comment.
@thcyron thanks for the feedback! Do you have some spec documentation URL to reference here, or should we just follow whatever the CSI driver is doing?
There was a problem hiding this comment.
Unfortunately our metadata service is not documented. You can use all endpoints except local-ipv4 (since we don’t have private networking yet) as listed in this comment.
There was a problem hiding this comment.
Should we remove the local-ipv4 or can we keep it for now? For the moment it is not used anywhere but then the metadata service in coreos is already prepared for the moment Hetzner would add private networking (which would be awesome ;))?
There was a problem hiding this comment.
I think you can keep it. It’s no secret that we’ll offer private networking sooner or later and I’m pretty sure we’ll support the local-ipv4 endpoint then.
There was a problem hiding this comment.
It would be better to use the official endpoint http://169.254.169.254/hetzner/v1/metadata instead of the EC2-compat path
|
I think we can hold this PR for a moment and wait till the metadata endpoint is properly stabilized/documented. @LKaemmerling is there a public tracker where we can track progress on this? If not, can you maybe involve your colleagues directly here? |
|
@lucab I will inform you here if there is any progress. |
|
@lucab Now we have confirmation from the Hetzner team the metadata endpoint is stable, any chance we can get this PR merged? Or are there further changes needed? |
|
FYI: Our metadata documentation is now available: https://docs.hetzner.cloud/#overview-server-metadata |
|
Awesome! 👍 This slipped of my radar, I'll try to rebase this (and the related PRs) and make this mergeable again |
5 participants
Along with:
This will greatly enhance working with CoreOS on the Hetzner Cloud.