Skip to content

providers/hetzner: add support for Hetzner Cloud#996

Merged
prestist merged 2 commits intocoreos:mainfrom
mhutter:feat/hetzner
Sep 21, 2023
Merged

providers/hetzner: add support for Hetzner Cloud#996
prestist merged 2 commits intocoreos:mainfrom
mhutter:feat/hetzner

Conversation

@mhutter
Copy link
Contributor

@mhutter mhutter commented Sep 4, 2023

This commit implements initial support for Hetzner Cloud.

Supported features:

  • Attributes
  • Hostname
  • SSH Keys

"hetzner" was choosen as the platform identifier, as proposed in coreos/fedora-coreos-tracker#1324 (comment).

Note that I decided to open a new PR over #125, since

  • there was no activity in said PR for 4 years
  • I did not want to bother with rebasing (I did not even try)
  • I cannot push commits to existing PRs

but I don't have any hard feelings regarding merging this into #125 either.

Depending on how this goes I can work on the Ignition part as well later on.

Resolves: #125
Relates: coreos/fedora-coreos-tracker#1324

Signed-off-by: Manuel Hutter <manuel@hutter.io>
Copy link
Contributor

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hetzner Cloud employee here 👋 This looks good from a metadata service usage perspective.

Does the provider also need to implement the networks related methods from MetadataProvider (e.g. networks, virtual_network_devices, rd_network_kargs) or are these optional?

@mhutter
Copy link
Contributor Author

mhutter commented Sep 5, 2023

As I understand them they are optional, and configuration via DHCP "just works" in my tests, however I could imagine that this could be implemented in the future.

For example, it would be interesting to have somewhat stable interface identifiers (if that is even doable) for servers that have both public and internal IP's.

@prestist
Copy link
Contributor

prestist commented Sep 6, 2023

@mhutter Firstly thank you so much for working on this. I wanted to update you and let you know I will be taking a look at this PR in the coming days. I will try and get back to you with any questions soon. Thank you again!

This commit implements initial support for Hetzner Cloud.

Supported features:
- Attributes
- Hostname
- SSH Keys

"hetzner" was choosen as the platform identifier, as proposed in [1].

[1]: coreos/fedora-coreos-tracker#1324 (comment)

Resolves: #125
Relates: coreos/fedora-coreos-tracker#1324
Signed-off-by: Manuel Hutter <manuel@hutter.io>
@mhutter mhutter changed the title feat(hetzner): Initial support for Hetzner Cloud providers/hetzner: add support for Hetzner Cloud Sep 7, 2023
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking through the changes, I do not have any suggestions. Great job, and thank you for working so diligently on this.

ps, thank you for the clippy cleanup !

LGTM!

@prestist prestist merged commit 296d08d into coreos:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants