Skip to content

Fix race condition in Subscription#verify! #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bellisabell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix race condition in Subscription#verify! #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/models/subscription.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ def self.new_token
end

def verify!
already_verified = verified_at.present?
self.verified_at = Time.zone.now
self.unsubscribed_at = nil
save!

send_new_subscriber_notification unless already_verified
with_lock do
already_verified = verified_at.present?
self.verified_at = Time.zone.now
self.unsubscribed_at = nil
save!

send_new_subscriber_notification unless already_verified
end
end

# Sends verification email.
Expand Down