Open
Conversation
Wrap verify! in with_lock to prevent concurrent execution that could send duplicate new subscriber notifications. The race condition occurred when two concurrent requests both checked verified_at.present? before either had saved, causing both to send notifications. Closes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
verify!method inSubscriptionhas a race condition that can send duplicate new subscriber notifications.When two concurrent requests call
verify!on the same subscription:verified_at.present?→ both seenilverified_atand savesend_new_subscriber_notificationSolution
Wrap the
verify!method inwith_lockto use pessimistic database row-level locking. This ensures only one process can read and modify the record at a time, making the check-then-act pattern atomic.Closes #29