COMCL-1326: Fix Batch Export To Quickbooks #37
Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR fixes the QuickBooks export functionality by filtering out credit note allocation transactions from the batch export query. Previously, allocation transactions were included in the result set (as they are needed for Sage50 export), but these transactions appear as incomplete records in QuickBooks exports and need to be excluded.
Key changes:
- Modified the WHERE clause in the QuickBooks export query to exclude allocation transactions that lack corresponding financial transaction or item relationships
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Overview
This PR fixes the result set while exporting a batch to quickbooks that contains credit note allocation transactions, we recently started showing allocation transactions in the batch creation screen that were needed for sage50 export but for quickbooks export we dont need these allocation transactions in exported file so this PR fixes the query for quickbooks export to remove the allocation transaction records as they were coming out as incomplete in quickbooks export.