CIVIMM-351: Change Tax Amount Column In Sage50 Report #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukh-compuco
force-pushed
the
civimm-351-fix-empty-tax-amount
branch
from
ee96509 to
6754520
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Sage50 CSV report to display the tax amount column as 0.00 instead of blank for transactions without a tax amount.
- Set default
TAX_AMOUNT_LABELvalue to0instead ofNULL - Apply
number_formatto always show two decimal places
Comments suppressed due to low confidence (1)
CRM/Financial/BAO/ExportFormat/DataProvider/Sage50CSVProvider.php:199
- Add a test case to verify that when no tax amount is provided, the CSV output shows "0.00" in the tax amount column.
$formattedItem[self::TAX_AMOUNT_LABEL] = number_format((float) $formattedItem[self::TAX_AMOUNT_LABEL], 2, '.', '');
| } | ||
| } | ||
|
|
||
| $formattedItem[self::TAX_AMOUNT_LABEL] = number_format((float) $formattedItem[self::TAX_AMOUNT_LABEL], 2, '.', ''); |
There was a problem hiding this comment.
[nitpick] Consider extracting this number_format call into a helper for formatting monetary values consistently across all monetary columns.
erawat
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes the tax amount column in sage50 report to appear as 0.00 instead of blank for transactions where there is no tax amount.
Before
before.csv
After
after.csv