Fix installer logging: use Burn /log flag instead of msiexec /lv*x#54
Merged
compnerd merged 1 commit intocompnerd:mainfrom Mar 10, 2026
Merged
Conversation
The Swift Windows installer is a WiX Burn bundle, not a raw MSI.
The /lv*x flag is an msiexec option that Burn silently ignores
("Ignoring unknown argument"), so install.log was never created.
Replace with /log, which is the correct Burn CLI flag for logging.
Also use backslash in the path for consistency on Windows.
compnerd
approved these changes
Mar 10, 2026
roman-bcny
added a commit
to thebrowsercompany/swift-build
that referenced
this pull request
Mar 10, 2026
The WiX Burn installer log is useful for diagnosing install failures (e.g. PATH race conditions). Print it inline in the job output. Depends on upstream fix: compnerd/gha-setup-swift#54 (gha-setup-swift currently passes /lv*x which Burn ignores; the fix switches to /log so the log file is actually created)
roman-bcny
added a commit
to thebrowsercompany/swift-build
that referenced
this pull request
Mar 10, 2026
Print the WiX Burn installer log inline in the job output after Swift toolchain setup. Useful for diagnosing install failures. Depends on compnerd/gha-setup-swift#54 to create the log file (current /lv*x flag is silently ignored).
Contributor
Author
|
@compnerd fyi I don't have the "merge" button on my end |
roman-bcny
added a commit
to thebrowsercompany/swift-build
that referenced
this pull request
Mar 10, 2026
* Print Swift installer log after setup Print the WiX Burn installer log inline in the job output after Swift toolchain setup. Useful for diagnosing install failures. Depends on compnerd/gha-setup-swift#54 to create the log file (current /lv*x flag is silently ignored). * Upload installer log as artifact instead of printing inline --------- Co-authored-by: Roman Lavrov <roman.lavrov@thebrowser.company>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift Windows installer is a WiX Burn bundle, not a raw MSI. The
/lv*xflag is an msiexec option that Burn silently ignores (Ignoring unknown argumentin the Burn log), soinstall.logwas never created.This replaces
/lv*xwith/log, which is the correct WiX Burn CLI flag for specifying the log file path.