Skip to content

Print Swift installer log after setup#338

Merged
roman-bcny merged 2 commits intomainfrom
romanl/fix-installer-logging
Mar 10, 2026
Merged

Print Swift installer log after setup#338
roman-bcny merged 2 commits intomainfrom
romanl/fix-installer-logging

Conversation

@roman-bcny
Copy link
Copy Markdown
Contributor

@roman-bcny roman-bcny commented Mar 10, 2026

Print the WiX Burn installer log inline in the job output after Swift toolchain setup. Potentially useful for diagnosing install failures (e.g. the one I saw where PATH is not being set correctly flakily).

Silently skips if no log file is present. Once compnerd/gha-setup-swift#54 lands (fixes /lv*x -> /log), the log file will be created.

Print the WiX Burn installer log inline in the job output after
Swift toolchain setup. Useful for diagnosing install failures.

Depends on compnerd/gha-setup-swift#54
to create the log file (current /lv*x flag is silently ignored).
@roman-bcny roman-bcny requested a review from compnerd March 10, 2026 19:54
@roman-bcny roman-bcny marked this pull request as ready for review March 10, 2026 19:54
Copy link
Copy Markdown
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we should just upload this as an artifact instead. This is going to slow down the UI too much.

@roman-bcny roman-bcny requested a review from compnerd March 10, 2026 20:33
Copy link
Copy Markdown
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we should just upload this as an artifact instead. This is going to slow down the UI too much.

@roman-bcny roman-bcny merged commit 8511504 into main Mar 10, 2026
8 checks passed
@roman-bcny roman-bcny deleted the romanl/fix-installer-logging branch March 10, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants