Skip to content

add parenthesis to _print_ and use method _warning_ instead of _warn_ #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gamboz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add parenthesis to _print_ and use method _warning_ instead of _warn_ #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions collective/watcherlist/mailer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ def simple_send_mail(message, addresses, subject, immediate=False):
"""
mail_host = utils.get_mail_host()
if mail_host is None:
logger.warn("Cannot send notification email: please configure "
"MailHost correctly.")
logger.warning("Cannot send notification email: please configure "
"MailHost correctly.")
# We print some info, which is perfect for checking in unit
# tests.
print 'Subject =', subject
print 'Addresses =', addresses
print 'Message ='
print message
print('Subject =', subject)
Copy link
Member

@mauritsvanrees mauritsvanrees Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Python 3 this is good.
On Python2 the result is ugly:

>>> print("subject =", "foo")
('subject =', 'foo')

print('Addresses =', addresses)
print('Message =')
print(message)
return

mfrom = utils.get_mail_from_address()
Expand Down