add parenthesis to _print_ and use method _warning_ instead of _warn_#10
Open
gamboz wants to merge 1 commit intocollective:masterfrom
Open
add parenthesis to _print_ and use method _warning_ instead of _warn_#10gamboz wants to merge 1 commit intocollective:masterfrom
gamboz wants to merge 1 commit intocollective:masterfrom
Conversation
mauritsvanrees
requested changes
Nov 21, 2019
Member
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
Thanks for picking this up. The change is mostly good, but I have a comment that should be addressed.
Also, the tests on Travis are failing. That is not caused by your PR, but it would be good if you could look into it. I am not actively using this package currently.
(I think I still have one customer who uses it, but I don't think I can even reach the server...)
| print 'Addresses =', addresses | ||
| print 'Message =' | ||
| print message | ||
| print('Subject =', subject) |
Member
There was a problem hiding this comment.
On Python 3 this is good.
On Python2 the result is ugly:
>>> print("subject =", "foo")
('subject =', 'foo')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to install Products.Poi 4.0.2 on Plone 5.2 (python 3) and the installer complains that the syntax of
printis wrong.Also,
logging.warnseems to be deprecated in favor oflogging.warning.