-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: Algorand x402 Specification Proposal #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
|
@ehanoc is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey all, With #705 nearly complete, we encourage you to rebase off of the |
Hey @CarsonRoscoe , thanks for getting back to us. I had a look at that branch and it seems to be touching mostly implementations, we are only submitting the specification here as suggested by the CONTRIBUTING.md guide. We are ready to submit an implementation if we can get a review on this and approval first. Would that be possible? |
edcalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hey @CarsonRoscoe , any chance we could have someone have a look at this? |
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach seems logical. Most feedback is about upgrading this to target version 2
CarsonRoscoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing, virtually all my requested changes are just about targetting v2 over v1.
The meat of the proposal is logical and I am content with, once the v2 updates are in we'll be good to merge
Signed-off-by: ehanoc <bruno.martins@algorand.foundation> Co-authored-by: cusma <cosimo.bassi@algorand.foundation> Co-authored-by: tasosbit <tasos.bitsios@algorand.foundation> Co-authored-by: nullun <steve.ferrigno@algorand.foundation> Co-authored-by: tasosbit <tasos.bitsios@algorand.foundation> Co-authored-by: emg110 <emg110@gmail.com>
Thanks so much for reviewing @CarsonRoscoe . I've just made the updates, rebased and pushed. Let me know if there's anything else! |
Description
Submitting proposal for Algorand's x402 support.
The proposal takes advantages of Algorand's Native Atomic Transaction Groups, Instant finality and the ability to fee pooling to comply with the requirements of x402 protocol.
Future
Upon review and if accepted, we are committed to submit the actual implementation