You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@vsalvino Came here from #69. Poking around at the failing test_struct_org test, one thing I noticed is that you are applying @cached_property to methods that return mutable objects (seo_struct_org_base_dict and seo_struct_org_dict). But seo_struct_org_dict calls update on the value that is returned from seo_struct_org_base_dict, meaning that it's updating the cached value that the base property returns. I'm not sure if that's what's causing the specific error since the output doesn't show the actual response contents, but that seems incorrect regardless.
I'm not sure what the best solution overall is, but theoretically you could apply the @cached_property decorate only on properties that return immutable values, like seo_struct_org_base_json and seo_struct_org_json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
Should lead to a slight performance improvement.