Open
Conversation
When using returning mutable objects from @cached_property, the same dictionary object is shared between different calls, meaning that any modifications to the returned dictionary will also show up in the "cached" property. As an example, when if you call `seo_struct_org_base_dict` on an object, then call `seo_struct_org_dict`, and then call `seo_struct_org_base_dict`, it will return the extended dictionary, because `seo_struct_org_dict` calls `.update()` on the base dict. I've changed the `@cached_property` to `@property` on the four methods that return dictionaries. It's safe to leave it on the `_json` methods since those return immutable strings.
Author
|
Darn, it appears I didn't manage to stop it failing on 3.9. I don't know if that's an issue given that it's officially out of support since October 31st, but apologies for a PR that doesn't pass tests. I was really sure that was the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes #73, adds a commit to fix the issue of caching a mutable object, and rebases the branch onto
main.