Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions controllers/masteruserrecord/sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -905,37 +905,6 @@ func TestRoutes(t *testing.T) {
AllUserAccountsHaveCondition(condition)
})

t.Run("che route is missing but condition is ready", func(t *testing.T) {
// given
toolchainStatus := NewToolchainStatus(
WithMember(test.MemberClusterName, WithRoutes("https://console.member-cluster/", ToBeReady())))
mur := masterUserRec.DeepCopy()

hostClient := test.NewFakeClient(t, mur, toolchainStatus)
sync := Synchronizer{
record: mur,
hostClient: hostClient,
memberCluster: newMemberCluster(memberClient),
memberUserAcc: userAccount,
logger: l,
}

// when
err := sync.synchronizeStatus(context.TODO())

// then
require.NoError(t, err)
uatest.AssertThatUserAccount(t, "john", memberClient).
Exists().
MatchMasterUserRecord(mur).
HasConditions(condition)
murtest.AssertThatMasterUserRecord(t, "john", hostClient).
AllUserAccountsHaveCluster(toolchainv1alpha1.Cluster{
Name: test.MemberClusterName,
}).
AllUserAccountsHaveCondition(condition)
})

t.Run("condition is not ready", func(t *testing.T) {
// given
toolchainStatus := NewToolchainStatus(
Expand Down
2 changes: 1 addition & 1 deletion pkg/segment/hash.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

// Hashes the given username to anonymize the data sent to Segment (and subsequently Woopra)
//
// Note: implementation of the Hash MUST match with the existing ones of CRW and Web/Dev Console
// Note: implementation of the Hash MUST match with the existing Web/Dev Console
// so that metrics can be correlated in Woopra
// See https://github.com/che-incubator/che-workspace-telemetry-client/pull/68/files
func Hash(username string) string {
Expand Down
Loading