Removing the leftover related to CHE

[fbm3307]

there was a review comment from coderabit, #1209 (comment), reomving the leftover

Summary by CodeRabbit

• Tests

  • Removed a test case for route validation logic.

• Chores

  • Updated internal documentation reference in hash implementation code.

[coderabbitai]

Walkthrough

This pull request removes a test case from the MasterUserRecord sync tests that verified behavior when a Che route was missing but conditions were ready, and updates an inline comment in the hash module to reflect that the hash implementation only needs to match the Web/Dev Console, not CRW.

Changes

Cohort / File(s)	Summary
Test case removal controllers/masteruserrecord/sync_test.go	Deleted the "che route is missing but condition is ready" test case from TestRoutes, including its setup, invocation, and assertions
Comment update pkg/segment/hash.go	Updated inline comment in Hash() function to clarify hash alignment requirement is with Web/Dev Console only, not CRW

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Test case removal is straightforward but benefits from understanding why Che route validation is no longer tested
• Comment change is minimal and low-risk, though context around hash implementation alignment is helpful

Possibly related PRs

• SANDBOX-1392: Drop dependency on Che instance #1202: Broader removal of Che-related routes and fields with corresponding test adjustments

Suggested reviewers

• MatousJobanek
• alexeykazakov

Poem

🐰 A test for routes now fades away,
Where Che once danced but couldn't stay,
The hash sings true to Console's song,
Comments corrected, intentions strong!
✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'Removing the leftover related to CHE' accurately describes the main changes in the changeset. Both modifications—removing the test case related to Che route handling and updating the comment in hash.go to remove the reference to CRW—are directly related to removing CHE-related code and references. The title is concise, clear, and captures the primary intent of the PR as described in the objectives.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fc7ca6 and 69126a4.

📒 Files selected for processing (2)

• controllers/masteruserrecord/sync_test.go (0 hunks)
• pkg/segment/hash.go (1 hunks)

💤 Files with no reviewable changes (1)

• controllers/masteruserrecord/sync_test.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: GolangCI Lint
• GitHub Check: Test with Coverage
• GitHub Check: Build & push operator bundles for e2e tests

🔇 Additional comments (2)

pkg/segment/hash.go (2)

10-10: Comment update correctly removes CHE reference.

The updated comment accurately reflects the requirement: the hash implementation needs to match only the Web/Dev Console, not CRW. This aligns with the PR's objective of removing CHE-related leftovers and clarifies the maintenance requirement for future developers.

---

13-16: Function implementation remains correct.

The Hash function body is unchanged and correctly implements SHA1-based anonymization for username hashing, with appropriate gosec annotation. No behavioral changes introduced.

---

Summary

The changes in this file are minimal and well-targeted: the comment update removes the now-stale reference to CRW (a CHE-related component) while preserving the clarification that the hash implementation must align with the Web/Dev Console. This is a clean, non-functional change that directly addresses the PR's stated objective of removing CHE leftovers. ✅

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rsoaresd]

🚀

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, rajivnathan, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,fbm3307,rajivnathan,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.84%. Comparing base (bd01295) to head (e22ebfe).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1211   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files          83       83           
  Lines        6483     6483           
=======================================
  Hits         4593     4593           
  Misses       1681     1681           
  Partials      209      209           

Files with missing lines	Coverage Δ
pkg/segment/hash.go	100.00% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.