Skip to content

Make three notices sticky #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andy1li wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −41
Open

Make three notices sticky #3740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f94c7
Refactor overlays to use conditional rendering instead of animated co…
andy1li Feb 11, 2026
b2a4f85
Implement click handler for modal dismissal in TestsPassedOverlay com…
andy1li Feb 11, 2026
287cce0
Remove unused fade transition from course page overlay components to …
andy1li Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions app/components/course-page/course-stage-step/tests-passed-overlay.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@
...attributes
>
<:content>
<AnimatedContainer>
{{#animated-if this.modalWasDismissed duration=150 use=this.transition}}
<CoursePage::CourseStageStep::TestsPassedNotice
class="px-3 md:px-6 lg:px-10 w-full scroll-mt-20"
{{! Ensure this is visible when modal is dismissed }}
{{upscroll-on-insert scrollableContainer="#course-page-scrollable-area"}}
{{on "click" (fn (mut this.modalWasDismissed) false)}}
/>
{{/animated-if}}
</AnimatedContainer>
{{#if this.modalWasDismissed}}
<CoursePage::CourseStageStep::TestsPassedNotice
class="sticky top-10 z-10 px-3 md:px-6 lg:px-10 w-full scroll-mt-20"
{{! Ensure this is visible when modal is dismissed }}
{{upscroll-on-insert scrollableContainer="#course-page-scrollable-area"}}
{{on "click" this.handleNoticeClick}}
/>
{{/if}}

{{yield}}
</:content>
Expand Down
8 changes: 5 additions & 3 deletions app/components/course-page/course-stage-step/tests-passed-overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import Component from '@glimmer/component';
import type CourseStageStep from 'codecrafters-frontend/utils/course-page-step-list/course-stage-step';
import { action } from '@ember/object';
import { tracked } from '@glimmer/tracking';
import fade from 'ember-animated/transitions/fade';

interface Signature {
Element: HTMLDivElement;
Expand All @@ -17,8 +16,6 @@ interface Signature {
}

export default class TestsPassedOverlay extends Component<Signature> {
transition = fade;

@tracked lastSeenStepId: string | null = null;
@tracked modalWasDismissed = false;

Expand All @@ -31,6 +28,11 @@ export default class TestsPassedOverlay extends Component<Signature> {
this.modalWasDismissed = true;
}

@action
handleNoticeClick() {
this.modalWasDismissed = false;
}

@action
handleStepIdUpdated() {
if (this.args.currentStep.id === this.lastSeenStepId) {
Expand Down
22 changes: 10 additions & 12 deletions app/components/course-page/current-step-complete-overlay.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,16 @@
...attributes
>
<:content>
<AnimatedContainer>
{{#animated-if this.modalWasDismissed duration=150 use=this.transition}}
<CoursePage::CompletedStepNotice
{{! @glint-expect-error repository is nullable according to coursePageState }}
@repository={{this.coursePageState.stepList.repository}}
@step={{@currentStep}}
class="px-3 md:px-6 lg:px-10 w-full scroll-mt-20"
{{! Ensure this is visible when modal is dismissed }}
{{upscroll-on-insert scrollableContainer="#course-page-scrollable-area"}}
/>
{{/animated-if}}
</AnimatedContainer>
{{#if this.modalWasDismissed}}
<CoursePage::CompletedStepNotice
{{! @glint-expect-error repository is nullable according to coursePageState }}
@repository={{this.coursePageState.stepList.repository}}
@step={{@currentStep}}
class="sticky top-10 z-10 px-3 md:px-6 lg:px-10 w-full scroll-mt-20"
{{! Ensure this is visible when modal is dismissed }}
{{upscroll-on-insert scrollableContainer="#course-page-scrollable-area"}}
/>
{{/if}}

{{yield}}
</:content>
Expand Down
3 changes: 0 additions & 3 deletions app/components/course-page/current-step-complete-overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { service } from '@ember/service';
import Component from '@glimmer/component';
import type CoursePageStateService from 'codecrafters-frontend/services/course-page-state';
import { StepDefinition } from 'codecrafters-frontend/utils/course-page-step-list';
import fade from 'ember-animated/transitions/fade';

interface Signature {
Element: HTMLDivElement;
Expand All @@ -19,8 +18,6 @@ interface Signature {
}

export default class CurrentStepCompleteOverlay extends Component<Signature> {
transition = fade;

@tracked modalWasDismissed = false;
@tracked lastSeenStepStatus: string | null = null;

Expand Down
18 changes: 8 additions & 10 deletions app/components/course-page/previous-steps-incomplete-overlay.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@
...attributes
>
<:content>
<AnimatedContainer>
{{#animated-if this.modalWasDismissed duration=150 use=this.transition}}
<CoursePage::PreviousStepsIncompleteNotice
@step={{@currentStep}}
class="px-3 md:px-6 lg:px-10 w-full scroll-mt-20"
{{! Ensure this is visible when modal is dismissed }}
{{upscroll-on-insert scrollableContainer="#course-page-scrollable-area"}}
/>
{{/animated-if}}
</AnimatedContainer>
{{#if this.modalWasDismissed}}
<CoursePage::PreviousStepsIncompleteNotice
@step={{@currentStep}}
class="sticky top-10 z-10 px-3 md:px-6 lg:px-10 w-full scroll-mt-20"
{{! Ensure this is visible when modal is dismissed }}
{{upscroll-on-insert scrollableContainer="#course-page-scrollable-area"}}
/>
{{/if}}

{{yield}}
</:content>
Expand Down
3 changes: 0 additions & 3 deletions app/components/course-page/previous-steps-incomplete-overlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { service } from '@ember/service';
import Component from '@glimmer/component';
import type CoursePageStateService from 'codecrafters-frontend/services/course-page-state';
import { StepDefinition } from 'codecrafters-frontend/utils/course-page-step-list';
import fade from 'ember-animated/transitions/fade';

interface Signature {
Element: HTMLDivElement;
Expand All @@ -19,8 +18,6 @@ interface Signature {
}

export default class PreviousStepsIncompleteOverlay extends Component<Signature> {
transition = fade;

@tracked modalWasDismissed = false;
@tracked lastSeenStepStatus: string | null = null;

Expand Down
Loading