Open
Conversation
…ntainers for modal dismissal. This change improves performance and simplifies the component structure across current-step-complete, previous-steps-incomplete, and tests-passed overlays.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…ponent. This change replaces the previous click event binding with a dedicated action method, improving code clarity and maintainability.
This comment has been minimized.
This comment has been minimized.
…streamline code and improve performance.
|
Bugbot Autofix prepared fixes for 1 of the 1 bugs found in the latest run.
Or push these changes by commenting: Preview (22f7fdd2ef)diff --git a/app/components/course-page/course-stage-step/tests-passed-overlay.ts b/app/components/course-page/course-stage-step/tests-passed-overlay.ts
--- a/app/components/course-page/course-stage-step/tests-passed-overlay.ts
+++ b/app/components/course-page/course-stage-step/tests-passed-overlay.ts
@@ -2,7 +2,6 @@
import type CourseStageStep from 'codecrafters-frontend/utils/course-page-step-list/course-stage-step';
import { action } from '@ember/object';
import { tracked } from '@glimmer/tracking';
-import fade from 'ember-animated/transitions/fade';
interface Signature {
Element: HTMLDivElement;
@@ -17,8 +16,6 @@
}
export default class TestsPassedOverlay extends Component<Signature> {
- transition = fade;
-
@tracked lastSeenStepId: string | null = null;
@tracked modalWasDismissed = false;
diff --git a/app/components/course-page/current-step-complete-overlay.ts b/app/components/course-page/current-step-complete-overlay.ts
--- a/app/components/course-page/current-step-complete-overlay.ts
+++ b/app/components/course-page/current-step-complete-overlay.ts
@@ -4,7 +4,6 @@
import Component from '@glimmer/component';
import type CoursePageStateService from 'codecrafters-frontend/services/course-page-state';
import { StepDefinition } from 'codecrafters-frontend/utils/course-page-step-list';
-import fade from 'ember-animated/transitions/fade';
interface Signature {
Element: HTMLDivElement;
@@ -19,8 +18,6 @@
}
export default class CurrentStepCompleteOverlay extends Component<Signature> {
- transition = fade;
-
@tracked modalWasDismissed = false;
@tracked lastSeenStepStatus: string | null = null;
diff --git a/app/components/course-page/previous-steps-incomplete-overlay.ts b/app/components/course-page/previous-steps-incomplete-overlay.ts
--- a/app/components/course-page/previous-steps-incomplete-overlay.ts
+++ b/app/components/course-page/previous-steps-incomplete-overlay.ts
@@ -4,7 +4,6 @@
import Component from '@glimmer/component';
import type CoursePageStateService from 'codecrafters-frontend/services/course-page-state';
import { StepDefinition } from 'codecrafters-frontend/utils/course-page-step-list';
-import fade from 'ember-animated/transitions/fade';
interface Signature {
Element: HTMLDivElement;
@@ -19,8 +18,6 @@
}
export default class PreviousStepsIncompleteOverlay extends Component<Signature> {
- transition = fade;
-
@tracked modalWasDismissed = false;
@tracked lastSeenStepStatus: string | null = null; |
Bundle ReportChanges will increase total bundle size by 1.26kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Member
|
Good idea - on my list for tomorrow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Cannot quite make the stickiness compatible with animation.
Checklist:
[percy]in the message to trigger)Note
Low Risk
UI-only behavior and styling changes (animation removal + sticky positioning) with minimal logic impact; main risk is visual/regression around notice visibility and layering while scrolling.
Overview
When overlay modals are dismissed on the course page, the corresponding notices are now rendered as sticky banners (
sticky top-10 z-10) instead of being shown viaember-animated(AnimatedContainer/animated-if).This removes the
fadetransition wiring from the three overlay components, and updates the tests-passed notice to be clickable to re-open the modal (handleNoticeClick).Written by Cursor Bugbot for commit 287cce0. This will update automatically on new commits. Configure here.