Skip to content

cleanup: fix no-op condition and typo in ChecksNotifier [6/6] #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thomasrockhu-codecov wants to merge 1 commit into
base: refactor/checks-notifier-breakup
Choose a base branch
from
+2 −2
Draft

cleanup: fix no-op condition and typo in ChecksNotifier [6/6] #699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/worker/services/notification/notifiers/checks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def _validate_pull_request(

Returns a NotificationResult if validation fails, or None to continue.
"""
if comparison.pull is None or ():
if comparison.pull is None:
log.debug(
"Falling back to commit_status: Not a pull request",
extra={
Expand Down Expand Up @@ -280,7 +280,7 @@ def _build_payload_with_behavior(

def get_line_diff(self, file_diff):
"""
This method traverses a git file diff and returns the lines (as line numbers) that where chnaged
This method traverses a git file diff and returns the lines (as line numbers) that were changed
Note: For now it only looks for line additions on diff, we can quickly add functionality to handle
line deletions if needed

Expand Down
Loading