cleanup: fix no-op condition and typo in ChecksNotifier [6/6]#699
Draft
thomasrockhu-codecov wants to merge 1 commit intorefactor/checks-notifier-breakupfrom
Draft
cleanup: fix no-op condition and typo in ChecksNotifier [6/6]#699thomasrockhu-codecov wants to merge 1 commit intorefactor/checks-notifier-breakupfrom
thomasrockhu-codecov wants to merge 1 commit intorefactor/checks-notifier-breakupfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/checks-notifier-breakup #699 +/- ##
===================================================================
Coverage ? 92.35%
===================================================================
Files ? 1302
Lines ? 47829
Branches ? 1619
===================================================================
Hits ? 44171
Misses ? 3349
Partials ? 309
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…fier - Fix 'comparison.pull is None or ()' to 'comparison.pull is None' in _validate_pull_request — the 'or ()' was a no-op since () is falsy, so the expression was equivalent to just 'is None' - Fix typo "where chnaged" -> "were changed" in get_line_diff docstring Co-authored-by: Cursor <cursoragent@cursor.com>
thomasrockhu-codecov
force-pushed
the
refactor/checks-notifier-cleanup
branch
from
1feba2c to
9f669c9
Compare
thomasrockhu-codecov
force-pushed
the
refactor/checks-notifier-breakup
branch
from
814ca05 to
35c9ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup PR stacked on the ChecksNotifier refactoring PR (#695). Fixes a subtle logic issue and a docstring typo.
Changes
comparison.pull is None or ()→comparison.pull is Nonein_validate_pull_request— theor ()was a no-op since()(empty tuple) is falsy in Python, so theorbranch always evaluated to()which is falsy, making the entire expression equivalent to justis None. This was likely a copy-paste error from the original code that was moved into the new helper method.get_line_diffdocstring: "where chnaged" → "were changed"Test plan
ruff checkandruff formatpassMade with Cursor