Skip to content

refactor(utils): extract DrawResetButton helper in settings #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xq-r wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(utils): extract DrawResetButton helper in settings #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 42 additions & 34 deletions src/utils/settings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,47 @@ static Setting* FindSetting(const std::string& key) {
return nullptr;
}

static bool DrawResetButton(Setting* setting, const char* id = nullptr) {
bool changed = false;
const bool is_using_default = (setting->GetValue() == setting->default_value);
ImGui::BeginDisabled(is_using_default);
if (is_using_default) {
ImGui::PushStyleColor(ImGuiCol_Button, ImVec4(ImColor::HSV(0, 0, 0.6f)));
ImGui::PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(ImColor::HSV(0, 0, 0.7f)));
ImGui::PushStyleColor(ImGuiCol_ButtonActive, ImVec4(ImColor::HSV(0, 0, 0.8f)));
}
auto* font = ImGui::GetFont();
auto old_scale = font->Scale;
auto previous_font_size = ImGui::GetFontSize();
font->Scale *= 0.75f;
ImGui::PushFont(font);
auto current_font_size = ImGui::GetFontSize();

ImGui::PushStyleVar(ImGuiStyleVar_FrameRounding, current_font_size * 2);

ImVec2 cursor_pos = ImGui::GetCursorPos();
cursor_pos.y += (previous_font_size / 2.f) - (current_font_size / 2.f);
ImGui::SetCursorPos(cursor_pos);

const std::string btn_id = (id != nullptr) ? id : ("##Reset" + (setting->key.empty() ? setting->label : setting->key));
ImGui::PushID(btn_id.c_str());
if (ImGui::Button(renodx::utils::icons::View(renodx::utils::icons::UNDO))) {
setting->Set(setting->default_value);
changed = true;
}
ImGui::PopID();

if (is_using_default) {
ImGui::PopStyleColor(3);
}
font->Scale = old_scale;
ImGui::PopFont();
ImGui::PopStyleVar();
ImGui::EndDisabled();

return changed;
}

static bool UpdateSetting(const std::string& key, float value) {
auto* setting = FindSetting(key);
if (setting == nullptr) return false;
Expand Down Expand Up @@ -570,40 +611,7 @@ static void OnRegisterOverlay(reshade::api::effect_runtime* runtime) {
&& setting->can_reset
&& setting->value_type < SettingValueType::BUTTON) {
ImGui::SameLine();
const bool is_using_default = (setting->GetValue() == setting->default_value);
ImGui::BeginDisabled(is_using_default);
if (is_using_default) {
ImGui::PushStyleColor(ImGuiCol_Button, ImVec4(ImColor::HSV(0, 0, 0.6f)));
ImGui::PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(ImColor::HSV(0, 0, 0.7f)));
ImGui::PushStyleColor(ImGuiCol_ButtonActive, ImVec4(ImColor::HSV(0, 0, 0.8f)));
}
auto* font = ImGui::GetFont();
auto old_scale = font->Scale;
auto previous_font_size = ImGui::GetFontSize();
font->Scale *= 0.75f;
ImGui::PushFont(font);
auto current_font_size = ImGui::GetFontSize();

ImGui::PushStyleVar(ImGuiStyleVar_FrameRounding, current_font_size * 2);

ImVec2 cursor_pos = ImGui::GetCursorPos();
cursor_pos.y += (previous_font_size / 2.f) - (current_font_size / 2.f);
ImGui::SetCursorPos(cursor_pos);

ImGui::PushID(("##Reset" + identifier).c_str());
if (ImGui::Button(renodx::utils::icons::View(renodx::utils::icons::UNDO))) {
setting->Set(setting->default_value);
changed = true;
}
ImGui::PopID();

if (is_using_default) {
ImGui::PopStyleColor(3);
}
font->Scale = old_scale;
ImGui::PopFont();
ImGui::PopStyleVar();
ImGui::EndDisabled();
changed |= DrawResetButton(setting);
}

if (changed) {
Expand Down
Loading