refactor(utils): extract DrawResetButton helper in settings#543
Open
xq-r wants to merge 1 commit intoclshortfuse:mainfrom
Open
refactor(utils): extract DrawResetButton helper in settings#543xq-r wants to merge 1 commit intoclshortfuse:mainfrom
xq-r wants to merge 1 commit intoclshortfuse:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the settings UI overlay to extract the “reset to default” ImGui button drawing logic into a reusable helper for consistent styling across standard and custom settings.
Changes:
- Added a
DrawResetButton(Setting* setting, const char* id = nullptr)helper to encapsulate the reset button rendering and behavior. - Replaced the inline reset-button drawing block in
OnRegisterOverlaywith a call to the new helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing access to this is useful for visual consistency with custom settings.