Skip to content

Fix stale cached frequency in PWM auto-allocation #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cleishm merged 1 commit into from
Mar 31, 2026
Merged

Fix stale cached frequency in PWM auto-allocation #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions components/idfxx_pwm/src/pwm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const char* TAG = "idfxx::pwm";
struct timer_state {
std::mutex mutex;
uint8_t resolution_bits = 0; // 0 = unconfigured
uint32_t frequency_hz = 0;
int8_t clk_source = 0;
};
timer_state timers[LEDC_SPEED_MODE_MAX][SOC_LEDC_TIMER_NUM];
Expand Down Expand Up @@ -141,7 +140,6 @@ result<void> timer::try_configure(const struct config& cfg) {
{
auto& state = timers[to_ledc(_speed_mode)][_num];
std::scoped_lock lock(state.mutex);
state.frequency_hz = static_cast<uint32_t>(cfg.frequency.count());
state.clk_source = static_cast<int8_t>(std::to_underlying(cfg.clk_source));
state.resolution_bits = cfg.resolution_bits;
}
Expand Down Expand Up @@ -263,7 +261,7 @@ result<output> try_start(idfxx::gpio gpio, const timer::config& cfg, const outpu
}
continue;
}
if (state.frequency_hz == static_cast<uint32_t>(cfg.frequency.count()) &&
if (ledc_get_freq(ledc_mode, static_cast<ledc_timer_t>(t)) == static_cast<uint32_t>(cfg.frequency.count()) &&
state.resolution_bits == cfg.resolution_bits &&
state.clk_source == static_cast<int8_t>(std::to_underlying(cfg.clk_source))) {
matched_timer = t;
Expand Down
Loading