Fix stale cached frequency in PWM auto-allocation#33
Merged
Conversation
The auto-allocating try_start() cached the timer frequency in a static struct for matching, but try_set_frequency() and external ESP-IDF calls updated the hardware without updating the cache. Replace the cached comparison with ledc_get_freq() to always read the actual frequency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frequency_hzfromtimer_statein PWM auto-allocationledc_get_freq()when matching timerstry_set_frequency()or direct ESP-IDF callsThe other cached fields (
resolution_bits,clk_source) are retained — they can only change vialedc_timer_config()(i.e.try_configure()), which updates the cache, and no ESP-IDF getter exists to read them back.