Adding Imaris File Reading to Brieflow supported filetypes.#193
Open
joandrews33 wants to merge 6 commits intocheeseman-lab:mainfrom
Open
Adding Imaris File Reading to Brieflow supported filetypes.#193joandrews33 wants to merge 6 commits intocheeseman-lab:mainfrom
joandrews33 wants to merge 6 commits intocheeseman-lab:mainfrom
Conversation
…d metadatafile and a per image bundled metadata file at the same time, but I couldn't make this work with snakemake. Reverting to legacy behavior.
Author
|
Ready for review. Changes to scripts/preprocessing/extract_metadata.py can be safely rejected, as my pipeline doesn't need them as is, but they would be necessary if I wanted to incorporate automatic pixel size determination, which requires cross-referencing two different metadata files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding an Imaris File reader to extend supported file types. Reads in metadata bundled with each Imaris image file, and converts images to tiff files.
I also added support in the workflow/scripts/preprocessing/extract_metadata.py to allow the ability to use both bundled metadata and a separate metadata file together when extracting metadata (because Imaris has per image and additional per job metadata files), but I wasn't able to get this to integrate with snakemake without making deeper structural changes to the code base. I commented out the new code, and reverted the behavior to legacy out of worry for breaking support for workflows that need a separated metadata file, but if it works with those workflows, it may be useful new functionality.
What is the nature of your change?
Enhancement (adds functionality)
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
pyproject.tomlto reflect the change as designated by semantic versioning.ruff checkandruff format.