Refactor mobile menu scrolling behaviour#63
Open
roundaboutluke wants to merge 5 commits intoccev:mainfrom
Open
Refactor mobile menu scrolling behaviour#63roundaboutluke wants to merge 5 commits intoccev:mainfrom
roundaboutluke wants to merge 5 commits intoccev:mainfrom
Conversation
Owner
|
sorry to say but this didn't really help much, i've just pushed a change where some offsetting issues are gone, but the sticky title still juggles around while scrolling. also now the bottom padding is fucked up. i also noticed you removed the extra scout menu styling; admittedly it's a bit of a hack, but now the scout menu styling is also fucked up. |
Contributor
Author
|
Might be best to leave this for now - I've got a friend bringing me an old android soon, I'll be able to test on a real device then Annoying that I could replicate in the Android Studio emulator and as you saw got it perfect there so a real device to get it right is the only way forward I think (side by side with iPhone to ensure compatibility with both that is!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue on Android Chrome where the menu behaved incorrectly when the viewport height changes as the address bar shows/hides.
The bug was reproduced in Android Studio emulator and fix was tested there also please test on a real device to confirm its resolved.
iOS Safari remains working with these changes. Android Firefox has not been tested.
Note: there is still an existing issue on Android Chrome where if the address bar is hidden and the menu is closed via the X button then the address bar does not reappear. This behavior actually existed prior to this change (and my last PR from testing) and is not introduced here.