Skip to content

Refactor mobile menu scrolling behaviour #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roundaboutluke wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Refactor mobile menu scrolling behaviour #63

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b20a110
Refactor mobile menu to avoid Chrome scroll jank
roundaboutluke Dec 18, 2025
6327230
Update MobileMenu height class for responsiveness
roundaboutluke Dec 18, 2025
b778528
fix weird offset
ccev Dec 20, 2025
f3b8b67
put scout back 🙇‍♂️
roundaboutluke Dec 20, 2025
ed95b5d
Merge branch 'ccev:main' into chrome-scroll-fix
roundaboutluke Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/components/menus/MobileMenu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import CloseButton from '@/components/ui/CloseButton.svelte';
import * as m from '@/lib/paraglide/messages';
import { Drawer } from 'vaul-svelte';
import { onMount, onDestroy } from 'svelte';
</script>

<Drawer.Root
Expand All @@ -14,15 +15,18 @@
>
<Drawer.Portal>
<Drawer.Content
class="after:h-0! duration-150! touch-auto! fixed z-10 w-full h-full overflow-y-scroll bottom-0 pointer-events-auto overscroll-contain"
style="{getOpenedMenu() === 'scout' ? 'height: fit-content !important;' : '' }; -webkit-overflow-scrolling: touch; touch-action: pan-y;"
class="absolute left-0 bottom-0 z-10 pointer-events-none h-full w-full"
style="{getOpenedMenu() === 'scout' ? 'height: fit-content !important;' : ''}"
>
<div
class="pb-20 px-2 pt-2 mt-40 min-h-full rounded-t-xl border border-t-border bg-card/60 backdrop-blur-sm"
out:slide={{ duration: 70, axis: 'y' }}
class="h-full overflow-y-auto"
style="-webkit-overflow-scrolling: touch;"
>
<div class="sticky top-2 z-20">
<div class="w-full py-1 flex items-center justify-between bg-card/60 backdrop-blur-sm rounded-lg border border-border">
<div
class="pb-20 px-2 pt-2 mt-40 min-h-full rounded-t-xl border border-t-border bg-card/60 backdrop-blur-sm pointer-events-auto"
out:slide={{ duration: 70, axis: 'y' }}
>
<div class="w-full py-1 sticky top-2 flex items-center justify-between z-10 bg-card/60 backdrop-blur-sm rounded-lg border border-border">
<Drawer.Title
level="h1"
class="font-bold text-base tracking-tight mx-4"
Expand All @@ -34,9 +38,9 @@
class="mr-1 hover:bg-accent/90! active:bg-accent/90!"
/>
</div>
</div>

<MenuContainer />
<MenuContainer />
</div>
</div>
</Drawer.Content>
</Drawer.Portal>
Expand Down