Skip to content

homepage style tweaks #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccbrown merged 1 commit into from
May 24, 2025
Merged

homepage style tweaks #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions frontend/src/app/(public-area)/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,28 @@ const Page = () => {
</Link>
</div>
</div>
<div className="flex-1 flex flex-col bg-dark-purple text-snow rounded-lg p-4">
<h2>
<Link href="/articles/capital-one-data-breach" className="link">
😱{' '}
<span className="text-amethyst-gradient">Capital One Data Breach – A Cautionary Tale</span>
</Link>
</h2>
<div className="text-sm text-amethyst">
What&apos;s in your <s>wallet</s> cloud?
<div className="flex-1 flex flex-col translucent-snow rounded-lg p-4">
<div className="flex gap-4 items-center">
<Image
src="/images/chris.jpg"
alt={`By Chris`}
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt text is not descriptive of the image content. Consider using something like alt="Photo of Chris" to better convey the image purpose to screen readers.

Suggested change
alt={`By Chris`}
alt="Photo of Chris"

Copilot uses AI. Check for mistakes.
height={48}
width={48}
className="rounded-full h-[48px] w-[48px]"
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using arbitrary pixel values (h-[48px] / w-[48px]) can hinder consistency. Consider replacing with Tailwind spacing utilities (e.g. h-12 w-12) to align with your design system.

Suggested change
className="rounded-full h-[48px] w-[48px]"
className="rounded-full h-12 w-12"

Copilot uses AI. Check for mistakes.
/>
<div>
<h2>
<Link href="/articles/capital-one-data-breach" className="link">
<span className="text-amethyst-gradient">
Capital One Data Breach – A Cautionary Tale
</span>{' '}
😱
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone emoji will be announced by screen readers, which may be distracting. Wrap it in a <span aria-hidden="true"> or add role="img" aria-hidden="true" so it's purely decorative.

Suggested change
😱
<span aria-hidden="true">😱</span>

Copilot uses AI. Check for mistakes.
</Link>
</h2>
<div className="text-sm text-amethyst">
What&apos;s in your <s>wallet</s> cloud?
</div>
</div>
</div>
<p className="text-sm mt-4">
Capital One lost hundreds of millions after being notified by a third party of an intruder that
Expand All @@ -88,7 +101,7 @@ const Page = () => {
<div className="flex mt-8 items-center gap-2">
<Link
href="/articles/capital-one-data-breach"
className="snow-button flex grow-0 items-center whitespace-nowrap"
className="button flex grow-0 items-center whitespace-nowrap"
>
Read More
<ChevronRightIcon className="h-4 w-4 ml-2" />
Expand Down
Loading