Skip to content

homepage style tweaks#36

Merged
ccbrown merged 1 commit intomainfrom
homepage-style-tweaks
May 24, 2025
Merged

homepage style tweaks#36
ccbrown merged 1 commit intomainfrom
homepage-style-tweaks

Conversation

@ccbrown
Copy link
Owner

@ccbrown ccbrown commented May 24, 2025

What It Does

Minor homepage style tweaks.

Copilot AI review requested due to automatic review settings May 24, 2025 02:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Minor visual refinements on the homepage feature card, including background updates, author thumbnail insertion, title layout adjustment, and button style change.

  • Replaced the dark purple card background with a translucent Snow variant and wrapped the card header in a flex container.
  • Inserted a circular author image and moved the emoji after the title text.
  • Swapped the snow-button class for the new generic button utility on the "Read More" link.
Comments suppressed due to low confidence (1)

frontend/src/app/(public-area)/page.tsx:104

  • [nitpick] The generic button class may collide with other styles in the project. Consider using a more specific utility or prefix (e.g. btn-primary) to avoid unintended overrides.
className="button flex grow-0 items-center whitespace-nowrap"

<div className="flex gap-4 items-center">
<Image
src="/images/chris.jpg"
alt={`By Chris`}
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt text is not descriptive of the image content. Consider using something like alt="Photo of Chris" to better convey the image purpose to screen readers.

Suggested change
alt={`By Chris`}
alt="Photo of Chris"

Copilot uses AI. Check for mistakes.
alt={`By Chris`}
height={48}
width={48}
className="rounded-full h-[48px] w-[48px]"
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using arbitrary pixel values (h-[48px] / w-[48px]) can hinder consistency. Consider replacing with Tailwind spacing utilities (e.g. h-12 w-12) to align with your design system.

Suggested change
className="rounded-full h-[48px] w-[48px]"
className="rounded-full h-12 w-12"

Copilot uses AI. Check for mistakes.
<span className="text-amethyst-gradient">
Capital One Data Breach – A Cautionary Tale
</span>{' '}
😱
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone emoji will be announced by screen readers, which may be distracting. Wrap it in a <span aria-hidden="true"> or add role="img" aria-hidden="true" so it's purely decorative.

Suggested change
😱
<span aria-hidden="true">😱</span>

Copilot uses AI. Check for mistakes.
@ccbrown ccbrown merged commit f7d4e11 into main May 24, 2025
3 checks passed
@ccbrown ccbrown deleted the homepage-style-tweaks branch May 24, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant