fix: non-utf-8 decode error #856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes UTF-8 decoding error when processing serial logs containing non-UTF-8 bytes (like
0xff).Description
PR #666 (Logging Redesign) introduced the
write_from_file()method without theerrors="ignore"parameter that the previous code used when reading serial logs.Added
encoding="utf-8", errors="ignore"to restore the exact previous behavior.Resolved issues
Documentation
Web service API changes
Tests