fix(agent): read serial file as binary if any invalid character #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 71.31% 71.34% +0.02%
==========================================
Files 108 108
Lines 9651 9659 +8
Branches 858 859 +1
==========================================
+ Hits 6883 6891 +8
Misses 2595 2595
Partials 173 173
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
ajzobro
reviewed
Dec 19, 2025
| assert len(requests) == 1 | ||
| assert requests[0].json()["fragment_number"] == 0 | ||
| assert requests[0].json()["phase"] == phase | ||
| assert requests[0].json()["log_data"] == "Boot OK\n\ufffd\ufffd\nDone" |
Contributor
There was a problem hiding this comment.
\xff and \xfe both reduce to \ufffd?
Contributor
Author
There was a problem hiding this comment.
Yes, both are replaced with U+FFFD � Replacement Character
Contributor
Author
|
Closing as this was fixed in #856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been noticing some RPI (muxpi device connector) provisioned successfully only to then proceed to the cleanup stage (skipping test and reserve phase). Since the status code (exit code) was not being sent at all to the server, my guess is that the code is breaking one step before during writing to serial endpoint.
Note: sending all other the results and phases status codes succeeds, provisioning status code was never retrieved/send to server
Since muxpi device connector are writing serial data as binary, in case there is any invalid character attempted to be read as text will raise a
UnicodeDecodeError.This PR adds catching this exception and reading it properly before being sent to server.
Resolved issues
CERTTF-784
Documentation
Web service API changes
Tests
Added one unit test to validate this behavior. Tested the unit test locally with and without fix in place
Before fix: