Skip to content

chore: fix error message for non-owned secrets in ops.testing #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: fix error message for non-owned secrets in ops.testing #2177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c3c134
Initial plan
Copilot Nov 14, 2025
9ba508e
Fix error message for managing granted secrets (owner=None)
Copilot Nov 14, 2025
cde472c
Apply code formatting (remove trailing whitespace)
Copilot Nov 14, 2025
ab4e79e
Remove new test and keep original error message hint
Copilot Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/src/scenario/mocking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ def _check_can_manage_secret(
):
if secret.owner is None:
raise SecretNotFoundError(
'this secret is not owned by this unit/app or granted to it. '
'this secret is not owned by this unit/app. '
'Did you forget passing it to State.secrets?',
Copy link
Collaborator

@tonyandrewmeyer tonyandrewmeyer Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion is not correct - any time we get into _check_can_manage_secret we have retrieved the secret from the state, so we know that it's there.

What we should suggest is that they forgot to set the owner attribute on the testing.Secret.

Copy link
Contributor

@james-garner-canonical james-garner-canonical Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered that based on your comment on the issue. Sadly it looks like my comment along those lines got eaten (I probably left it in 'preview' mode before I submitted my review). Thanks for catching this.

)
if secret.owner == 'app' and not self.is_leader():
Expand Down