-
Notifications
You must be signed in to change notification settings - Fork 4
Support sharing the proxy-config via o7k-interface relation #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ | |
| """ | ||
|
|
||
| from operator import attrgetter | ||
| from typing import Dict | ||
|
|
||
| from charms.reactive import Endpoint | ||
| from charms.reactive import when | ||
|
|
@@ -109,7 +110,7 @@ def set_credentials(self, | |
| """ | ||
| Set the credentials for this request. | ||
| """ | ||
| self._unit.relation.to_publish.update({ | ||
| self._to_publish.update({ | ||
HomayoonAlimohammadi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 'auth_url': auth_url, | ||
| 'region': region, | ||
| 'username': username, | ||
|
|
@@ -137,7 +138,7 @@ def set_lbaas_config(self, | |
| """ | ||
| Set the load-balancer-as-a-service config for this request. | ||
| """ | ||
| self._unit.relation.to_publish.update({ | ||
| self._to_publish.update({ | ||
| 'subnet_id': subnet_id, | ||
| 'floating_network_id': floating_network_id, | ||
| 'lb_method': lb_method, | ||
|
|
@@ -154,15 +155,35 @@ def set_block_storage_config(self, | |
| """ | ||
| Set the block storage config for this request. | ||
| """ | ||
| self._unit.relation.to_publish.update({ | ||
| self._to_publish.update({ | ||
| 'bs_version': bs_version, | ||
| 'trust_device_path': trust_device_path, | ||
| 'ignore_volume_az': ignore_volume_az, | ||
| }) | ||
|
|
||
| @property | ||
| def proxy_config(self) -> Dict[str, str]: | ||
|
Comment on lines
+164
to
+165
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HomayoonAlimohammadi i switched this to a |
||
| """ | ||
| Get the proxy config answered on this request. | ||
|
|
||
| if `proxy_config` is not set, return an empty dict. | ||
| """ | ||
| data = self._to_publish.get('proxy_config') | ||
| if not data or not isinstance(data, dict): | ||
| return {} | ||
| return {k: (v or "") for k, v in data.items()} | ||
|
|
||
| def set_proxy_config(self, proxy_config: Dict[str, str]): | ||
| """ | ||
| Set the proxy config for this request. | ||
| """ | ||
| self._to_publish.update({ | ||
| 'proxy_config': proxy_config, | ||
| }) | ||
|
|
||
| @property | ||
| def has_credentials(self): | ||
| """ | ||
| Whether or not credentials have been set via `set_credentials`. | ||
| """ | ||
| return 'credentials' in self._unit.relation.to_publish | ||
| return 'credentials' in self._to_publish | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of
pydanticvalidators, we can trust that after callingself.is_readythat whatever is in proxy_config is eitherNoneorDict[str,str]