Support sharing the proxy-config via o7k-interface relation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Dyess <adam.dyess@canonical.com>
addyess
force-pushed
the
KU-3229/support-o7k-endpoint-through-proxy
branch
from
dd354af to
60d2982
Compare
HomayoonAlimohammadi
approved these changes
Apr 16, 2025
HomayoonAlimohammadi
left a comment
HomayoonAlimohammadi
left a comment
There was a problem hiding this comment.
Great work, thanks a lot @addyess! LGTM, left some minor nits and questions.
addyess
commented
Apr 16, 2025
Comment on lines
+164
to
+165
| @property | ||
| def proxy_config(self) -> Dict[str, str]: |
Contributor
Author
There was a problem hiding this comment.
@HomayoonAlimohammadi i switched this to a property to match the requires side of the relation
addyess
commented
Apr 16, 2025
| config = None | ||
| if self.is_ready and (data := self._data): | ||
| config = data.proxy_config | ||
| return config or {} |
Contributor
Author
There was a problem hiding this comment.
because of pydantic validators, we can trust that after calling self.is_ready that whatever is in proxy_config is either None or Dict[str,str]
addyess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: LP#2104884
share the following values over the
openstack-clientrelation so that openstack endpoints are contacted through the proxy:this dictionary will be filled by the
openstack-integratorwith the following env variables useful for proxying to openstack endpointsHTTP_PROXYHTTPS_PROXYNO_PROXY