Skip to content

Monitor-utility-rebase#59

Closed
JohnBrennan95 wants to merge 1 commit intomasterfrom
monitor-utility-rebase
Closed

Monitor-utility-rebase#59
JohnBrennan95 wants to merge 1 commit intomasterfrom
monitor-utility-rebase

Conversation

@JohnBrennan95
Copy link
Collaborator

Addresses previous monitor-utility branch. Tossing old monitor-utility code and starting fresh. Addressed all comments. Moved CLI to correct location, updated tests for monitor and cli, used valid monitor items and verified terraform. Integration tests passing and 12/12. No more manual monitor creations within the tests.

…mments. Moved CLI to correct location, updated tests for monitor and cli, used valid monitor items and verified terraform. Integration tests passing and 12/12. No more manual monitor creations within the tests.
@JohnBrennan95 JohnBrennan95 self-assigned this Jan 30, 2026
@JohnBrennan95 JohnBrennan95 added the enhancement New feature or request label Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 87.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.14%. Comparing base (2607688) to head (2837b92).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/critic/cli.py 64.28% 9 Missing and 1 partial ⚠️
src/critic/monitor_utility.py 90.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   90.06%   89.14%   -0.93%     
==========================================
  Files          13       15       +2     
  Lines         292      387      +95     
  Branches       20       25       +5     
==========================================
+ Hits          263      345      +82     
- Misses         24       34      +10     
- Partials        5        8       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@calebsyring
Copy link
Owner

Closing in favor of #62

@calebsyring calebsyring deleted the monitor-utility-rebase branch February 7, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants