Monitor Utility and Tests by JohnBrennan95 · Pull Request #47 · calebsyring/critic

JohnBrennan95 · 2026-01-10T23:37:01Z

Addresses issue #29.

Tests are working locally and inside a Docker container using pytest with a mocked DynamoDB environment. Monitor creation and deletion are functioning as expected. Next steps will need to focus on integration testing against real AWS resources and ensuring attributes match the assigned architecture.

codecov · 2026-01-10T23:38:51Z

Codecov Report

❌ Patch coverage is 49.15254% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.22%. Comparing base (7551e02) to head (27a122d).

Files with missing lines	Patch %	Lines
src/critic/monitor_utility.py	30.76%	18 Missing ⚠️
src/critic/app.py	66.66%	10 Missing ⚠️
src/critic/cli.py	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   83.87%   81.22%   -2.65%     
==========================================
  Files           9       10       +1     
  Lines         186      245      +59     
  Branches       14       17       +3     
==========================================
+ Hits          156      199      +43     
- Misses         26       41      +15     
- Partials        4        5       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

calebsyring

Requested some changes.

A few of them will depend on a PR I should get out shortly.

calebsyring · 2026-01-12T14:08:15Z

src/critic/monitor_utility.py

+    with t.batch_writer() as bw:
+        for i in range(1, count + 1):
+            slug = f'{prefix}-{i:04d}'
+            bw.put_item(Item={'project_id': project_id, 'slug': slug})


Part of the point of this is to have operational monitors. So that we can actually run checks at scale.

These at least need a url (you can use google.com or something if you want) and probably some other fields. Maybe just make sure that your fake data passes the model validation.

calebsyring · 2026-01-12T14:11:01Z

src/critic/app.py

+@app.route('/monitors/create')
+def create_monitors_route():
+    # SImple start to get monitor going
+    table_name = os.environ.get('MONITOR_TABLE_NAME', 'Critic-Monitors')


You're right that table names probably need to be defined via environment variables.

I'll take care of that in a pr I'm working on.

calebsyring · 2026-01-12T14:11:24Z

src/critic/app.py

+        project_id=project_id,
+        prefix=prefix,
+        count=count,
+        ddb=None,  # Uses a boto3 ddb resource


I'll also have a universal ddb instance that can be accessed instead of passing it through all the time.

calebsyring · 2026-01-12T14:13:53Z

src/critic/app.py

    raise RuntimeError('Deliberate runtime error')


+@app.route('/monitors/create')


These should be CLI commands and not routes. These are open to the public and anyone could hit them. It's also a somewhat clunky UX to have to go that url for your lambda instead of just calling it via CLI.

There's a example here in mu for exposing CLI commands: https://github.com/level12/mu/blob/master/examples/mu_hello/mu_hello.py

calebsyring · 2026-01-12T14:16:18Z

src/critic_tests/monitor_test.py

+TABLE_NAME = 'UptimeMonitor'
+
+
+def _create_test_table():


Shouldn't need this because of

critic/tests/critic_tests/conftest.py

Line 41 in 6e58869

create_tables()

Wait to fix until I get my PR out and you rebase. It'll be easier to use.

calebsyring · 2026-01-12T14:17:07Z

src/critic_tests/monitor_test.py

+    # Create 10 monitors
+    created = create_monitors(
+        table_name=TABLE_NAME,
+        project_id=project_id,


Note that this assumes the existence of a project.

We'll need some way to create a project. Maybe you're just planning on that being done in the console manually?

…ew comments

calebsyring · 2026-01-22T21:13:03Z

src/critic/cli.py

@@ -1,2 +1,10 @@
+from critic.app import cli


The point of this file is to have cli stuff in here. See https://github.com/level12/coppy/blob/main/src/coppy/cli.py

We should be able to just import it for the ActionHandler as needed.

calebsyring · 2026-01-22T21:16:11Z

src/critic/monitor_utility.py

+    with t.batch_writer() as bw:
+        for i in range(1, count + 1):
+            slug = f'{prefix}-{i:04d}'
+            bw.put_item(Item=_monitor_item(project_id=project_id, slug=slug))


Use the put method on the table. Should vastly simplify this file. The batch writer isn't that important here AFAIK

calebsyring · 2026-01-22T21:18:10Z

src/critic_tests/monitor_test.py

@@ -0,0 +1,80 @@
+import boto3
+from boto3.dynamodb.conditions import Key
+from moto import mock_aws


Shouldn't need this. AWS should be mocked automatically for any test not marked an integration test.

calebsyring · 2026-01-22T21:19:13Z

src/critic_tests/monitor_test.py

+from critic.tables import UptimeMonitorTable
+
+
+def _create_test_table(ddb):


Shouldn't need to create tables... If you have to, something is wrong with moto_for_unit_tests

…ew comments

…s. No more manual monitor creations within the tests. Added new fixtures and conftest files to assist with testing, may not be needed but helped validate functionality.

calebsyring · 2026-01-30T14:39:34Z

Closing in favor of #59

JohnBrennan95 requested a review from calebsyring January 10, 2026 23:37

JohnBrennan95 self-assigned this Jan 10, 2026

JohnBrennan95 added the enhancement New feature or request label Jan 10, 2026

calebsyring requested changes Jan 12, 2026

View reviewed changes

Monitor Utility and Tests

1461832

JohnBrennan95 force-pushed the monitor-stress-utility branch from 7c53137 to 1461832 Compare January 16, 2026 23:49

Modifications to monitor utility functionality made based off of revi…

27a122d

…ew comments

calebsyring requested changes Jan 22, 2026

View reviewed changes

calebsyring and others added 5 commits January 25, 2026 13:42

Run due checks

810aee3

Fix QA env

e84bdca

Monitor Utility and Tests

1df08fd

Modifications to monitor utility functionality made based off of revi…

b7ce8d3

…ew comments

Moved CLI to correct location, updated tests, used valid monitor item…

49d8ece

…s. No more manual monitor creations within the tests. Added new fixtures and conftest files to assist with testing, may not be needed but helped validate functionality.

calebsyring closed this Jan 30, 2026

		raise RuntimeError('Deliberate runtime error')


		@app.route('/monitors/create')

		from critic.tables import UptimeMonitorTable


		def _create_test_table(ddb):

Conversation

JohnBrennan95 commented Jan 10, 2026

Uh oh!

codecov bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

calebsyring left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calebsyring commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 10, 2026 •

edited

Loading