-
Notifications
You must be signed in to change notification settings - Fork 104
Dispatch a Authentication.authenticate event on successful authentication. #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * CakePHP(tm) : Rapid Development Framework (https://cakephp.org) | ||
| * Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org) | ||
| * | ||
| * Licensed under The MIT License | ||
| * For full copyright and license information, please see the LICENSE.txt | ||
| * Redistributions of files must retain the above copyright notice. | ||
| * | ||
| * @copyright Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org) | ||
| * @link https://cakephp.org CakePHP(tm) Project | ||
| * @since 3.4.0 | ||
| * @license https://opensource.org/licenses/mit-license.php MIT License | ||
| */ | ||
| namespace Authentication\Event; | ||
|
|
||
| use Authentication\AuthenticationServiceInterface; | ||
| use Authentication\Authenticator\AuthenticatorInterface; | ||
| use Authentication\Authenticator\ResultInterface; | ||
| use Cake\Event\Event; | ||
| use InvalidArgumentException; | ||
| use Psr\Http\Message\RequestInterface; | ||
| use Psr\Http\Message\ServerRequestInterface; | ||
|
|
||
| /** | ||
| * Event triggered when authentication is run. | ||
| * | ||
| * @extends \Cake\Event\Event<\Authentication\AuthenticationServiceInterface> | ||
| */ | ||
| class AuthenticateEvent extends Event | ||
| { | ||
| /** | ||
| * Event name | ||
| * | ||
| * @var string | ||
| */ | ||
| public const NAME = 'Authentication.authenticate'; | ||
|
|
||
| /** | ||
| * Constructor | ||
| * | ||
| * @param string $name Name of the event | ||
| * @param \Authentication\AuthenticationServiceInterface $subject The Authentication service instance this event applies to. | ||
| * @param \Psr\Http\Message\ServerRequestInterface $request The request instance. | ||
| * @param \Authentication\Authenticator\AuthenticatorInterface $authenticator The authenticator instance. | ||
| * @param \Authentication\Authenticator\ResultInterface $result The authentication result. | ||
| */ | ||
| public function __construct( | ||
| string $name, | ||
| AuthenticationServiceInterface $subject, | ||
| ServerRequestInterface $request, | ||
| AuthenticatorInterface $authenticator, | ||
| ResultInterface $result, | ||
| ) { | ||
| $this->result = $result; | ||
|
|
||
| parent::__construct($name, $subject, compact('request', 'authenticator')); | ||
| } | ||
|
|
||
| /** | ||
| * The authentication result. | ||
| * | ||
| * @return \Authentication\Authenticator\ResultInterface | ||
| */ | ||
| public function getResult(): ResultInterface | ||
| { | ||
| return $this->result; | ||
| } | ||
|
|
||
| /** | ||
| * Set the authentication result. | ||
| * | ||
| * @param \Authentication\Authenticator\ResultInterface|null $value The result to set. | ||
| * @return $this | ||
| */ | ||
| public function setResult(mixed $value = null) | ||
| { | ||
| if (!$value instanceof ResultInterface) { | ||
| throw new InvalidArgumentException( | ||
| 'The result for Authentication.authenticate event must be a ' | ||
| . '`Authentication\Authenticator\ResultInterface` instance.', | ||
| ); | ||
| } | ||
|
|
||
| return parent::setResult($value); | ||
| } | ||
|
|
||
| /** | ||
| * Get the request instance. | ||
| * | ||
| * @return \Psr\Http\Message\RequestInterface | ||
| */ | ||
| public function getRequest(): RequestInterface | ||
| { | ||
| return $this->_data['request']; | ||
| } | ||
|
|
||
| /** | ||
| * Get the adapter options. | ||
| * | ||
| * @return \Authentication\Authenticator\AuthenticatorInterface | ||
| */ | ||
| public function getAuthenticator(): AuthenticatorInterface | ||
| { | ||
| return $this->_data['authenticator']; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok if this trigger on every request? Perhaps we should include that in the documentation?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. I overlooked the fact that this would trigger even when reading the user record from session. For the use cases I mentioned, the event is only needed for a login form POST. So triggering an event only from FormAuthenticate would make more sense.