Dispatch a Authentication.authenticate event on successful authentication.#729
Closed
Dispatch a Authentication.authenticate event on successful authentication.#729
Conversation
…ation. Subscribing to this event would allow the app to do to various like updating last login time, keep track of failed login attempts etc.
ADmad
changed the title
markstory
reviewed
Jul 21, 2025
| /** @var \Authentication\Authenticator\AuthenticatorInterface $authenticator */ | ||
| foreach ($this->authenticators() as $authenticator) { | ||
| $result = $authenticator->authenticate($request); | ||
| $result = $this->dispatchAuthenticateEvent( |
Member
There was a problem hiding this comment.
Is it ok if this trigger on every request? Perhaps we should include that in the documentation?
Member
Author
There was a problem hiding this comment.
Hmm.. I overlooked the fact that this would trigger even when reading the user record from session. For the use cases I mentioned, the event is only needed for a login form POST. So triggering an event only from FormAuthenticate would make more sense.
Member
Author
|
I'll revisit this in the future, closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscribing to this event would allow the app to do to various like updating last login time, keep track of failed login attempts etc.