Pass the MessageInfo object through to reply callbacks#107
Open
mephillips-durham wants to merge 1 commit intoc-jo:mainfrom
Open
Pass the MessageInfo object through to reply callbacks#107mephillips-durham wants to merge 1 commit intoc-jo:mainfrom
mephillips-durham wants to merge 1 commit intoc-jo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reply callback takes a single parameter, so that a callback may be implemented as a lambda, and so this was the poll block for the whole message, from which the message code could be extracted. But this means that the "code" passed to the reply handler is just the numeric code, whereas a message handler gets a MessageInfo object which allows it also to access the Wimp reason code.
Occasionally user messages are expected to receive a reply which uses the same message code. Being able to check if the reason code is 17/18 or 19 will help determine if it is a genuine reply or our own recorded delivery being bounced.
I chose the tuple to pass the two parameters as a single item, as it seemed the simplest solution: feel free to pick a different way of doing it.