Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: builds on #107
This change allows the developer to define how many seconds should pass before the reply callback should be called in the case of no reply and no bounce being received. When awaiting a reply to a recorded message, it is not always appropriate to alert the callback as soon as we get a null Wimp poll, because it is possible that the recipient of the message has acknowledged our message (to prevent a bounce) but is doing some background work before replying.
The timeout defaults to 0 seconds, to match the previous behaviour. It can be set to an appropriate number of seconds (or fractions of seconds) according to what is reasonable for the potential background processing. Or the reply_timeout can be set to None to wait indefinitely. In this situation it is possible that the reply_callback object will never be called or cleaned up.