bridge-sdk: Skip Minikube Dependent Tests When Unavailable
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2025
mhrheaume
reviewed
Dec 3, 2025
| }); | ||
| } | ||
|
|
||
| export const isMinikube = process.env.MINIKUBE_IP != undefined; |
Contributor
There was a problem hiding this comment.
I think we already have isHermeticTest that you can use?
|
|
||
| export const isMinikube = process.env.MINIKUBE_IP != undefined; | ||
| export const testMinikubeOnly = !isMinikube ? it.skip : it; | ||
| export const testMinikubeAndLocalOnly = process.env.GITHUB_ACTIONS || !isMinikube ? it.skip : it; |
Contributor
There was a problem hiding this comment.
Is this different from the default (where it runs regardless)?
Author
There was a problem hiding this comment.
wasn't sure if you ran github actions with minikube enabled internally, so wanted to check for it anyway to avoid undefined behaviour - can remove if unneeded.
Contributor
There was a problem hiding this comment.
Yeah we run GHA with minikube so I think this can be removed.
Contributor
|
@carsonp6 @coreymartin tagging you on this as well! |
…tic{AndLocal}Only`
Author
|
Hey @mhrheaume, missed this review - responded/fixed comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to b4d56fb.