Skip to content

fix: fix app starter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyrregjerstad merged 1 commit into from
Oct 27, 2025
Merged

fix: fix app starter #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/utils/buttons-app-starter/appStarter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export class AppStarter {

if (!isActive) {
this.masterPromise = Promise.resolve()
this.masterResolve = () => {}
this.masterReject = () => {}
Comment on lines +60 to +61
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

When isActive is false, the masterResolve and masterReject functions are not initialized. This can lead to errors later if these functions are called before being properly set up. Initializing them with empty functions ensures that they are always available, preventing potential issues.

Consider initializing masterResolve and masterReject with empty functions to avoid potential errors when isActive is false.

Suggested change
this.masterResolve = () => {}
this.masterReject = () => {}
this.masterResolve = () => {};
this.masterReject = () => {};

return
}

Expand Down
Loading