fix: fix app starter

[kyrregjerstad]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @kyrregjerstad, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a fix for the AppStarter utility by addressing a potential issue where internal promise resolution and rejection handlers might not be properly initialized. The change ensures that these handlers are always set to empty functions when the app starter is inactive, thereby preventing errors from attempting to invoke undefined functions.

Highlights

• App Starter Initialization: Ensured that masterResolve and masterReject functions are properly initialized to no-op functions when the app starter is not active, preventing potential runtime errors if these handlers were called while uninitialized.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a fix to the app starter, specifically addressing an issue where masterResolve and masterReject were not being initialized when the application was not active. This change ensures that these functions are properly initialized, preventing potential errors or unexpected behavior in such scenarios.

[gemini-code-assist]

When isActive is false, the masterResolve and masterReject functions are not initialized. This can lead to errors later if these functions are called before being properly set up. Initializing them with empty functions ensures that they are always available, preventing potential issues.

Consider initializing masterResolve and masterReject with empty functions to avoid potential errors when isActive is false.

Suggested change

	this.masterResolve = () => {}
	this.masterReject = () => {}
	this.masterResolve = () => {};
	this.masterReject = () => {};