Skip to content

patch emberplus connection #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phillipivan wants to merge 1 commit into from
Closed

patch emberplus connection #3839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .yarn/patches/emberplus-connection-npm-0.2.2-7dc017dd22.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
diff --git a/dist/Ember/Server/index.js b/dist/Ember/Server/index.js
index 209729f1858218bab9a6d733d4b6674abe981982..7b16ed5fb89580a6623e71046d97079e71b894ba 100644
--- a/dist/Ember/Server/index.js
+++ b/dist/Ember/Server/index.js
@@ -74,7 +74,12 @@ class EmberServer extends eventemitter3_1.EventEmitter {
const data = (0, ber_1.berEncode)([el], types_1.RootType.Elements);
let elPath = el.path;
if (el.contents.type !== model_1.ElementType.Node && !('targets' in update || 'sources' in update)) {
- elPath = elPath.slice(0, -2); // remove the last element number
+ const lastDotIndex = elPath.lastIndexOf('.')
+ if (lastDotIndex > -1) {
+ elPath = elPath.slice(0, lastDotIndex)
+ } else {
+ elPath = ''
+ }
}
for (const [path, clients] of Object.entries(this._subscriptions)) {
if (elPath === path) {
2 changes: 1 addition & 1 deletion companion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"dayjs": "^1.11.19",
"debounce-fn": "^6.0.0",
"ejson": "^2.2.3",
"emberplus-connection": "^0.2.2",
"emberplus-connection": "patch:emberplus-connection@npm%3A0.2.2#~/.yarn/patches/emberplus-connection-npm-0.2.2-7dc017dd22.patch",
"env-paths": "^3.0.0",
"express": "^5.1.0",
"express-serve-zip": "^1.1.0",
Expand Down
18 changes: 16 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11147,7 +11147,7 @@ asn1@evs-broadcast/node-asn1:
dayjs: "npm:^1.11.19"
debounce-fn: "npm:^6.0.0"
ejson: "npm:^2.2.3"
emberplus-connection: "npm:^0.2.2"
emberplus-connection: "patch:emberplus-connection@npm%3A0.2.2#~/.yarn/patches/emberplus-connection-npm-0.2.2-7dc017dd22.patch"
env-paths: "npm:^3.0.0"
express: "npm:^5.1.0"
express-serve-zip: "npm:^1.1.0"
Expand Down Expand Up @@ -12583,7 +12583,7 @@ asn1@evs-broadcast/node-asn1:
languageName: node
linkType: hard

"emberplus-connection@npm:^0.2.2":
"emberplus-connection@npm:0.2.2":
version: 0.2.2
resolution: "emberplus-connection@npm:0.2.2"
dependencies:
Expand All @@ -12597,6 +12597,20 @@ asn1@evs-broadcast/node-asn1:
languageName: node
linkType: hard

"emberplus-connection@patch:emberplus-connection@npm%3A0.2.2#~/.yarn/patches/emberplus-connection-npm-0.2.2-7dc017dd22.patch":
version: 0.2.2
resolution: "emberplus-connection@patch:emberplus-connection@npm%3A0.2.2#~/.yarn/patches/emberplus-connection-npm-0.2.2-7dc017dd22.patch::version=0.2.2&hash=03d251"
dependencies:
asn1: evs-broadcast/node-asn1
debug: "npm:^4.3.4"
eventemitter3: "npm:^4.0.7"
long: "npm:^3.2.0"
smart-buffer: "npm:^3.0.3"
tslib: "npm:^2.6.2"
checksum: 10c0/8861056d1012fa0830d70bff0f845ccc27e9169fba1e07198b22a97143cce04a7f39505b853da8ae4ec180d1bb5b1eae0a9b1ba741e0041c4b2b56d047276ff7
languageName: node
linkType: hard

"emoji-regex@npm:^10.3.0":
version: 10.6.0
resolution: "emoji-regex@npm:10.6.0"
Expand Down