Closed
Conversation
Member
|
maybe this should be submitted to the library too? I can create a v0.2.x branch there, and release it afterwards, unless you dont think this will be of benefit to anyone else |
Contributor
Author
|
If you create said 0.2 branch I will direct the PR there in case it's useful to others who can't or don't want to move to 0.3.x. |
Contributor
Author
|
Cool, I'll try and get to it later this week |
Contributor
Author
Julusian
added a commit
that referenced
this pull request
Dec 17, 2025
Member
|
Thanks, all merged and pulled in through 63a5262 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch commit
3722d65from sofie-emberplus-connection to v0.2.2Testing with emberplus viewer, behavior seems better when the internal variable parameters are defined in a flat structure (as opposed to a container node for each parameter). Previously, when testing during development of this feature, emberplus viewer could see the parameters, but subscriptions for updates were broken.
However altering the ember tree structure would be a breaking change and isn't part of this pull request.
As such this patch provides no immediate fix or improvement to Companion, but should put the emberplus api in a better place to accommodate any future development.