Remove uniffi build_foreign_language_testcases tests#858
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Sep 11, 2025
Merged
Conversation
7f0c145 to
35dcab1
Compare
reez
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should remove this test (only the Swift one remains, the others have been commented out because they didn't pass for some reason we couldn't figure out... basically proving my point) for 2 reasons:
cargo test --libjust to get around them (that's indeed why we have it set up that way in the justfile... to get around this test).I'm not against bringing them back one day if someone is interested in going down that rabbit hole, figuring out why they are useful, report back, and open a decent PR that uses them and shows why it's a plus for this codebase. For now, none of this has been done, and so their value is a net negative IMO.