Small refactors of Cargo.toml file#857
Merged
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom Sep 12, 2025
Merged
Conversation
ac8ecb7 to
1f7fbb9
Compare
1f7fbb9 to
4bad63f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been looking at our build process for a few days now and getting into all sort of rabbit holes. This PR does 2 things to bring the Cargo.toml file in line with the uniffi documentation on correct uniffi project setup:
libtype of crate type. This is because it is not required as no projects depend on bdk-ffi directly. It therefore adds an unnecessary burden to our build times by producing an artifact we don't need.The second commit just runs cargo update and commits the update to the dependency tree in the lock file.
Note: merge #858 first.