Skip to content

Small refactors of Cargo.toml file#857

Merged
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom
thunderbiscuit:fix/cargo-file
Sep 12, 2025
Merged

Small refactors of Cargo.toml file#857
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom
thunderbiscuit:fix/cargo-file

Conversation

@thunderbiscuit
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit commented Sep 11, 2025

I've been looking at our build process for a few days now and getting into all sort of rabbit holes. This PR does 2 things to bring the Cargo.toml file in line with the uniffi documentation on correct uniffi project setup:

  1. Remove the default feature and simply bring it on the uniffi dependency. This is just a way to make more explicit where the feature is turned on.
  2. Remove the lib type of crate type. This is because it is not required as no projects depend on bdk-ffi directly. It therefore adds an unnecessary burden to our build times by producing an artifact we don't need.

The second commit just runs cargo update and commits the update to the dependency tree in the lock file.

Note: merge #858 first.

Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4bad63f

Good alignment w uniffi docs, and this is cool Remove the lib type of crate type

@thunderbiscuit thunderbiscuit merged commit 4bad63f into bitcoindevkit:master Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants