Skip to content

test/getrandom-fallbacks: fix open shim types #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
besser82 merged 1 commit into from
Nov 22, 2025
Merged

test/getrandom-fallbacks: fix open shim types #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 40 additions & 6 deletions test/getrandom-fallbacks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,38 @@ __wrap_syscall(long number, ...)
there's no way to _clear_ that flag again. This test chooses to
exercise the read-failure path, not the open-failure path. */
#if defined HAVE_SYS_STAT_H && defined HAVE_FCNTL_H && defined HAVE_UNISTD_H

static bool open_needs_mode(int flags)
{
if (flags & O_CREAT)
{
return true;
}
#if defined(O_TMPFILE)
if ((flags & O_TMPFILE) == O_TMPFILE)
{
return true;
}
#endif
return false;
}

static bool urandom_should_fail = false;
static int urandom_fd = -1;
extern int __wrap_open (const char *, int, mode_t);
extern int __real_open (const char *, int, mode_t);
extern int __wrap_open (const char *, int, ...);
extern int __real_open (const char *, int, ...);
int
__wrap_open (const char *path, int flags, mode_t mode)
__wrap_open (const char *path, int flags, ...)
{
int mode = 0;
if (open_needs_mode(flags))
{
va_list args;
va_start(args, flags);
mode = va_arg(args, int);
va_end(args);
}

int ret = __real_open (path, flags, mode);
if (ret == -1)
return ret;
Expand All @@ -167,11 +192,20 @@ __wrap_open (const char *path, int flags, mode_t mode)
}

#ifdef HAVE_OPEN64
extern int __wrap_open64 (const char *, int, mode_t);
extern int __real_open64 (const char *, int, mode_t);
extern int __wrap_open64 (const char *, int, ...);
extern int __real_open64 (const char *, int, ...);
int
__wrap_open64 (const char *path, int flags, mode_t mode)
__wrap_open64 (const char *path, int flags, ...)
{
int mode = 0;
if (open_needs_mode(flags))
{
va_list args;
va_start(args, flags);
mode = va_arg(args, int);
va_end(args);
}

int ret = __real_open64 (path, flags, mode);
if (ret == -1)
return ret;
Expand Down
Loading