test/getrandom-fallbacks: fix open shim types#219
Merged
besser82 merged 1 commit intobesser82:developfrom Nov 22, 2025
Merged
Conversation
In C, functions taking a variable number of arguments are not guaranteed to have the same calling convention as functions taking a fixed number of arguments [^0]. Since `open()` and `open64()` are defined as taking a variable number of arguments, the `__wrap_open()` and `__wrap_open64()` mocks must be as well. [^0]: C23 §6.7.7.4¶14 says: "For two function types to be compatible, both shall specify compatible return types. Moreover, the parameter type lists shall agree in the number of parameters and in use of the final ellipsis; corresponding parameters shall have compatible types." This fixes the test on my powerpc64el machine building nixpkgs a8d610af3f1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #219 +/- ##
========================================
Coverage 90.12% 90.12%
========================================
Files 36 36
Lines 3767 3767
Branches 739 739
========================================
Hits 3395 3395
Misses 238 238
Partials 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for your contribution! This should at least partially fix #214. |
nwf
pushed a commit
to nwf/nixpkgs
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In C, functions taking a variable number of arguments are not guaranteed to have the same calling convention as functions taking a fixed number of arguments 1. Since
open()andopen64()are defined as taking a variable number of arguments, the__wrap_open()and__wrap_open64()mocks must be as well.This fixes the test on my powerpc64el machine building nixpkgs a8d610af3f1.
Footnotes
C23 §6.7.7.4¶14 says: "For two function types to be compatible, both shall specify compatible return types. Moreover, the parameter type lists shall agree in the number of parameters and in use of the final ellipsis; corresponding parameters shall have compatible types." ↩