Skip to content

Use Thread.each_caller_location over caller_locations #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuay03 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Thread.each_caller_location over caller_locations #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/marginalia/comment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,12 @@ def self.sidekiq_job
def self.line
Marginalia::Comment.lines_to_ignore ||= DEFAULT_LINES_TO_IGNORE_REGEX

last_line = caller_locations.detect do |loc|
!loc.path.match?(Marginalia::Comment.lines_to_ignore)
last_line = nil
Thread.each_caller_location do |loc|
if !loc.path.match?(Marginalia::Comment.lines_to_ignore)
last_line = loc
break
end
end
if last_line
last_line = last_line.to_s
Expand Down